fix: Billing Contact UI Regression from by MUI Update #9667
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
abailly-akamai
approved these changes
Sep 13, 2023
| @@ -140,7 +139,7 @@ const ContactInformation = (props: Props) => { | |||
| state || | |||
| zip || | |||
| country) && ( | |||
| <Box sx={sxBox}> | |||
| <Grid sx={sxGrid}> | |||
There was a problem hiding this comment.
Now that's it's a Grid I don't think you need the extra CSS here. You can most likely remove sxGrid sx all together
There was a problem hiding this comment.
Sadly, that did not work 😖
cpathipa
reviewed
Sep 13, 2023
There was a problem hiding this comment.
Adding m={0} at line 133 would also solves the issue and consistent with other boxes without having additional padding to subelements.
Also, you can completely lift sxGrid styles.
There was a problem hiding this comment.
We could do that, but do we really want to override MUI's Grid rules? Also, lifting lift sxGrid/sxBox styles still breaks some UI
jaalah-akamai
approved these changes
Sep 13, 2023
This was referenced Sep 15, 2023
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description 📝
http://localhost:3000/account/billing)The Fix 🔨
<Grid>to be a child of<Grid container>rather than a<Box>so it can correctly apply Grid stylesPreview 📷
How to test 🧪
http://localhost:3000/account/billingand check the alignment and responsiveness of the Billing Contact section